Stable merge for week 34 of 2022 #619
Conversation
* add ripgrep Co-authored-by: gbyl <[email protected]>
* add package: lf Co-authored-by: gbyl <[email protected]> Co-authored-by: Nathaniel van Diepen <[email protected]>
* upgrade to yaft-v0.0.7 * add rm1 input patch * update docker image version Co-authored-by: gbyl <[email protected]>
There was a problem hiding this comment.
Tested on rM 2.
rmfm starts fine from ssh, but does nothing when launched through remux.
Aug 21 20:29:21 reMarkable remux[8136]: env: can't execute 'node': No such file or directory
Given that node exists at /opt/bin/node I would guess that remux is missing or not transferring a PATH variable containing /opt/bin.
A quick temporary fix is to change/patch the shebang in /opt/bin/rmfm:
-#!/usr/bin/env node
+#!/opt/bin/nodeFor the long term, this should probably be adressed in remux (@raisjn).
Launching the app failes anyway though. I'm not sure here, but maybe node expects a full tty?
Aug 21 20:57:59 reMarkable remux[614]: /opt/bin/rmfm:52
Aug 21 20:57:59 reMarkable remux[614]: output = output.stdout.toString().trim();
Aug 21 20:57:59 reMarkable remux[614]: ^
Aug 21 20:57:59 reMarkable remux[614]: TypeError: Cannot read property 'toString' of null
Aug 21 20:57:59 reMarkable remux[614]: at ls (/opt/bin/rmfm:52:26)
Aug 21 20:57:59 reMarkable remux[614]: at Object.<anonymous> (/opt/bin/rmfm:402:1)
Aug 21 20:57:59 reMarkable remux[614]: at Module._compile (internal/modules/cjs/loader.js:1085:14)
Aug 21 20:57:59 reMarkable remux[614]: at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)
Aug 21 20:57:59 reMarkable remux[614]: at Module.load (internal/modules/cjs/loader.js:950:32)
Aug 21 20:57:59 reMarkable remux[614]: at Function.Module._load (internal/modules/cjs/loader.js:790:12)
Aug 21 20:57:59 reMarkable remux[614]: at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:76:12)
Aug 21 20:57:59 reMarkable remux[614]: at internal/main/run_main_module.js:17:47
Edit: The above issue seems to have the same root cause. output refers to running simple which is most likely not in $PATH either.
Edit: The other packages work fine.
|
@LinusCDE could you make the rmfm package maintainer aware of the issues you found? |
|
The thing is, I'm not sure if this is on the project maintainer to actually fix. His implementation is totally okay. This should be fixed in remux, as apps launched from opkg should have access to the paths in I tested a little, and it would probably be the easiest to add a patch for the rmfm package until it is fixed in remux. With this, remux can launch rmfm fine: -#!/usr/bin/env node
+#!/opt/bin/node
+process.env.PATH += ":/opt/bin" |
|
I'm creating a PR for patching this in as well as an issue for remux. |
|
Hotfix is created and tested to be working: #620 Including this here will fix rmfm for remux. New remux issue: rmkit-dev/rmkit#177 |
* Update Oxide to v2.4 * Update build image * Fix libsentry dependency version Co-authored-by: Linus K <[email protected]>
* Add path fix as mentioned in toltec-dev#619 * Fix patch problems and bump version
New Packages
rmfm- 1.4.0-1 (rmfm: Add version 1.3.0 #608 rmfm: Update to 1.4.0 #617)ripgrep- 13.0.0-1 (Add package: ripgrep #611)lf- r27-1 (Add package: lf #612)liboxide- 2.4-1 (Update Oxide to v2.4 #603)libsentry- 0.4.17 (Update Oxide to v2.4 #603)Updated Packages
yaft- 0.0.7-1 (Update yaft to v0.0.7 and add rM1 input patch #613)koreader- 2022.07-1 (Update KOReader to v2022.07 #609)erodefretoxiderottarnishdecaycorruptanxiety- 2.4-1 (Update Oxide to v2.4 #603)